Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove elasticsearch v5/v6 from tests #5451

Merged
merged 2 commits into from
May 15, 2024
Merged

Remove elasticsearch v5/v6 from tests #5451

merged 2 commits into from
May 15, 2024

Conversation

FlamingSaint
Copy link
Member

@FlamingSaint FlamingSaint commented May 13, 2024 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Removed instances of v5/v6 in the tests.

How was this change tested?

Checklist

@FlamingSaint
Remove elasticsearch v5/v6 from tests
8f41298 
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from a team as a code owner May 13, 2024 18:20
@FlamingSaint FlamingSaint requested a review from joe-elliott May 13, 2024 18:20
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label May 13, 2024
@codecov Codecov
Copy link

codecov bot commented May 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (afd39dd) to head (627da08).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5451   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         331      331           
  Lines       16113    16113           
=======================================
  Hits        15383    15383           
  Misses        556      556           
  Partials      174      174
Flag Coverage Δ
badger_v1 8.07% <ø> (ø)
cassandra-3.x-v1 16.48% <ø> (ø)
cassandra-3.x-v2 1.86% <ø> (ø)
cassandra-4.x-v1 16.48% <ø> (ø)
cassandra-4.x-v2 1.86% <ø> (ø)
elasticsearch-7.x 1.77% <ø> (-0.02%) ⬇️
elasticsearch-8.x 1.78% <ø> (ø)
grpc_v1 9.12% <ø> (ø)
grpc_v2 7.49% <ø> (ø)
kafka 9.81% <ø> (ø)
opensearch-1.x 1.77% <ø> (-0.02%) ⬇️
opensearch-2.x 1.77% <ø> (ø)
unittests 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yurishkuro
yurishkuro approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro enabled auto-merge (squash) May 13, 2024 22:17
@yurishkuro yurishkuro disabled auto-merge May 14, 2024 04:24
@yurishkuro
Copy link
Member

I initially thought you ran across flaky tests, but these are real errors:

=== RUN   TestIndexRollover_CreateIndicesWithILM/DefaultPolicyName/NoPrefix
    es_index_rollover_test.go:100: 
        	Error Trace:	/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:100
        	            				/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:76
        	Error:      	Received unexpected error:
        	            	elastic: Error 400 (Bad Request): Invalid index name [_ilm], must not start with '_', '-', or '+' [type=invalid_index_name_exception]

@FlamingSaint
Copy link
Member Author

I initially thought you ran across flaky tests, but these are real errors:

=== RUN   TestIndexRollover_CreateIndicesWithILM/DefaultPolicyName/NoPrefix
    es_index_rollover_test.go:100: 
        	Error Trace:	/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:100
        	            				/home/runner/work/jaeger/jaeger/plugin/storage/integration/es_index_rollover_test.go:76
        	Error:      	Received unexpected error:
        	            	elastic: Error 400 (Bad Request): Invalid index name [_ilm], must not start with '_', '-', or '+' [type=invalid_index_name_exception]

Okay. I will try fixing it.

@FlamingSaint
fix errors in CIT OpenSearch
627da08 
Signed-off-by: FlamingSaint <raghuramkannan400@gmail.com>
@FlamingSaint FlamingSaint requested a review from yurishkuro May 14, 2024 06:56
@yurishkuro yurishkuro enabled auto-merge (squash) May 14, 2024 14:00
@FlamingSaint
Copy link
Member Author

@yurishkuro is the error in the CIT badger v2 due to a flaky test ? I am not sure why the CI test for Badger v2 is failing

@yurishkuro
Copy link
Member

yes, most likely, thanks for reminding

@yurishkuro yurishkuro merged commit 91cffea into jaegertracing:main May 15, 2024
38 checks passed
@FlamingSaint FlamingSaint deleted the esv5/v6 branch May 24, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlamingSaint @yurishkuro